Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use storybook globals to store the current theme #55

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: use storybook globals to store the current theme #55

merged 1 commit into from
Dec 8, 2023

Conversation

gavmck
Copy link
Member

@gavmck gavmck commented Dec 8, 2023

Uses storybook globals to store the current theme and provide this to the story context.

This means we don't need to provide our own URL handler to set themes via URL so I've removed the old one (making this a breaking change)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mergify mergify bot merged commit 4f61729 into main Dec 8, 2023
7 checks passed
@mergify mergify bot deleted the fix/story-theme-hooks branch December 8, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshTheWanderer JoshTheWanderer JoshTheWanderer approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavmck @JoshTheWanderer